Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erp outputs endpoint #589

Merged
merged 10 commits into from
Jul 22, 2024
Merged

erp outputs endpoint #589

merged 10 commits into from
Jul 22, 2024

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Jul 2, 2024 •
edited

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) will edit wiki once merged into main

What kind of change does this PR introduce?

feature

What is the current behavior?

no erp/inputs (same as erp/help) or erp/outputs urls in the API

What is the new behavior (if this is a feature change)?

erp/inputs (same as erp/help) or erp/outputs urls added

Does this PR introduce a breaking change?

no

Other information:

once merged, update wiki adding
Get descriptions of possible ERP inputs: /erp/inputs?
Get descriptions of possible ERP outputs: /erp/outputs?
here:
https://github.com/NREL/REopt_API/wiki/1.-Structure-of-the-REopt-API#api-endpoints

@hdunham hdunham requested a review from Bill-Becker July 2, 2024 00:25
@Bill-Becker
Copy link
Collaborator

@hdunham I tried to spin the API up locally and test the endpoints, but I'm getting a "connection refused" error. The same GET request to the staging and production servers got a good response for the existing /help endpoint. You've tested this locally?

@hdunham
Copy link
Collaborator Author

hdunham commented Jul 10, 2024

@hdunham I tried to spin the API up locally and test the endpoints, but I'm getting a "connection refused" error. The same GET request to the staging and production servers got a good response for the existing /help endpoint. You've tested this locally?

That's weird, yeah I did test it locally. Let me look again.

@hdunham hdunham requested a review from adfarth July 18, 2024 15:46
adfarth
adfarth reviewed Jul 18, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
adfarth
adfarth reviewed Jul 18, 2024
View reviewed changes
resilience_stats/views.py Outdated Show resolved Hide resolved
@adfarth
Copy link
Collaborator

adfarth commented Jul 18, 2024

@hdunham I tried to spin the API up locally and test the endpoints, but I'm getting a "connection refused" error. The same GET request to the staging and production servers got a good response for the existing /help endpoint. You've tested this locally?

That's weird, yeah I did test it locally. Let me look again.

Oh I guess checking if this ended up working for you when you looked at it again?

@hdunham
Copy link
Collaborator Author

hdunham commented Jul 22, 2024

@hdunham I tried to spin the API up locally and test the endpoints, but I'm getting a "connection refused" error. The same GET request to the staging and production servers got a good response for the existing /help endpoint. You've tested this locally?

That's weird, yeah I did test it locally. Let me look again.

Oh I guess checking if this ended up working for you when you looked at it again?

Yeah I've tested it many times and it's always worked

@hdunham hdunham requested a review from adfarth July 22, 2024 17:40
adfarth
adfarth approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdunham approving, but looks like you may need to merge develop one more time to resolve merge conflicts

@hdunham hdunham removed the request for review from Bill-Becker July 22, 2024 19:12
@hdunham hdunham merged commit 9cf84ae into develop Jul 22, 2024
1 check passed
@hdunham hdunham deleted the erp-outputs-help branch July 22, 2024 20:12
@hdunham hdunham mentioned this pull request Jul 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adfarth adfarth adfarth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hdunham @Bill-Becker @adfarth